Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport: special handling for 404 response #290

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

axw
Copy link
Member

@axw axw commented Oct 29, 2018

Check for 404 responses, adding a hint that APM Server 6.5.0+ is required.

Closes #285

Check for 404 responses, adding a hint that
APM Server 6.5.0+ is required.
@codecov-io
Copy link

Codecov Report

Merging #290 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   80.56%   80.61%   +0.04%     
==========================================
  Files          96       96              
  Lines        5589     5592       +3     
==========================================
+ Hits         4503     4508       +5     
+ Misses        828      827       -1     
+ Partials      258      257       -1
Impacted Files Coverage Δ
transport/http.go 92.24% <100%> (+0.18%) ⬆️
tracer.go 84.68% <0%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcfa81c...4211341. Read the comment docs.

@axw axw merged commit aa86822 into elastic:master Oct 30, 2018
@axw axw deleted the transport-handle-404 branch October 30, 2018 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants