Metrics support (WIP) #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
stats-prototype
branch
2 times, most recently
from
debbbef
to
bb7821e
Compare
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
- Coverage 74.32% 70.51% -3.81%
==========================================
Files 60 56 -4
Lines 3131 3229 +98
==========================================
- Hits 2327 2277 -50
- Misses 620 777 +157
+ Partials 184 175 -9
Continue to review full report at Codecov.
|
axw
force-pushed
the
stats-prototype
branch
2 times, most recently
from
5af695b
to
57c45c6
Compare
|
Minimal program to send Prometheus's builtin Go metrics: package main
import (
"github.com/elastic/apm-agent-go"
"github.com/elastic/apm-agent-go/contrib/apmprometheus"
"github.com/prometheus/client_golang/prometheus"
)
func main() {
elasticapm.DefaultTracer.AddMetricsGatherer(apmprometheus.Wrap(prometheus.DefaultGatherer))
elasticapm.DefaultTracer.SendMetrics(nil)
} |
axw
commented
May 2, 2018
MetricsGatherer is an interface for gathering metrics. You add one to a Tracer using AddMetricsGatherer, and it is periodically called to gather all the metrics. Once they are gathered, they are sent in a payload to the Elastic APM server. Mostly for testing purposes, you can force metrics to be gathered and sent at any given time by calling Tracer.SendMetrics. It has the same sort of behaviour as Tracer.Flush, blocking until the metrics are sent or the abort channel is signaled.
Package apmprometheus provides a method for wrapping a prometheus.Gatherer to adapt it to the elasticapm.MetricsGatherer interface. Untyped, Gauge and Counter metric types are supported; Histogram and and Summary metrics are silently ignored for now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for metrics, including bridges for Prometheus and go-metrics. See commit messages for any non-obvious details.