Introduce Span.Subtype, Span.Action #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
==========================================
+ Coverage 81.09% 84.57% +3.48%
==========================================
Files 98 98
Lines 5877 5888 +11
==========================================
+ Hits 4766 4980 +214
Misses 840 840
+ Partials 271 68 -203
Continue to review full report at Codecov.
|
Introduce Span.Subtype and Span.Action. The type supplied via the StartSpan methods will now be split on dots, and the Type, Subtype, and Action fields populated in order.
axw
force-pushed
the
span-subtype-action
branch
from
2d9afd8
to
e0b103a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type supplied via the StartSpan methods will now be split on dots, and the Type, Subtype, and Action fields populated in order. If the type has only one dot, then action will not be set.
Closes #323