apm: fix data race accessing Tracer.active #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Tracer.loop exits, it sets Tracer.active to false, which races with reads by the method Tracer.Active. We fix this by changing the Tracer.active field from a bool to int32, and using atomic ops.
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
==========================================
+ Coverage 83.96% 83.98% +0.01%
==========================================
Files 102 102
Lines 6136 6137 +1
==========================================
+ Hits 5152 5154 +2
Misses 913 913
+ Partials 71 70 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Tracer.loop exits, it sets Tracer.active
to false, which races with reads by the method
Tracer.Active. We fix this by changing the
Tracer.active field from a bool to int32, and
using atomic ops.
Fixes #404