Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable agent.* metrics #407

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Conversation

axw
Copy link
Member

@axw axw commented Jan 4, 2019

Disable the agent.* metrics, as they were ill-defined.
We will reinstate these metrics, or some alternatives,
at a later date after design and discussion with other
agent developers.

Closes #396

Disable the `agent.*` metrics, as they were ill-defined.
We will reinstate these metrics, or some alternatives,
at a later date after design and discussion with other
agent developers.
@codecov-io
Copy link

codecov-io commented Jan 4, 2019

Codecov Report

Merging #407 into master will increase coverage by 3.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   80.63%   83.95%   +3.31%     
==========================================
  Files         102      102              
  Lines        6136     6126      -10     
==========================================
+ Hits         4948     5143     +195     
+ Misses        914      913       -1     
+ Partials      274       70     -204
Impacted Files Coverage Δ
builtin_metrics.go 91.56% <ø> (+6.45%) ⬆️
modelwriter.go 94.95% <0%> (+0.84%) ⬆️
internal/radix/radix.go 39.92% <0%> (+0.92%) ⬆️
utils.go 80.68% <0%> (+1.13%) ⬆️
internal/sqlscanner/scanner.go 96.82% <0%> (+1.58%) ⬆️
metrics.go 91.66% <0%> (+1.66%) ⬆️
error.go 77.45% <0%> (+1.73%) ⬆️
context.go 94.05% <0%> (+1.98%) ⬆️
internal/apmhttputil/url.go 97.87% <0%> (+2.12%) ⬆️
module/apmsql/stmt.go 63.82% <0%> (+2.12%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f89e36...ee98eeb. Read the comment docs.

@axw axw merged commit 2f96ceb into elastic:master Jan 4, 2019
@axw axw deleted the remove-agent-prefix-metrics branch January 4, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants