Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error.transaction.sampled #410

Merged
merged 3 commits into from
Jan 7, 2019
Merged

Conversation

axw
Copy link
Member

@axw axw commented Jan 7, 2019

Report whether or not an error occurred within a sampled transaction.

Closes #395

When setting an error's transaction or span details,
record whether or not the error occurred in a sampled
transaction.
@codecov-io
Copy link

codecov-io commented Jan 7, 2019

Codecov Report

Merging #410 into master will increase coverage by 3.32%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   80.57%   83.89%   +3.32%     
==========================================
  Files         102      102              
  Lines        6131     6149      +18     
==========================================
+ Hits         4940     5159     +219     
- Misses        917      919       +2     
+ Partials      274       71     -203
Impacted Files Coverage Δ
model/marshal.go 82.08% <100%> (+5.74%) ⬆️
error.go 76.24% <100%> (+2.5%) ⬆️
modelwriter.go 95.04% <100%> (+0.92%) ⬆️
model/marshal_fastjson.go 76.24% <90.9%> (+8.88%) ⬆️
internal/radix/radix.go 39.92% <0%> (+0.92%) ⬆️
utils.go 80.68% <0%> (+1.13%) ⬆️
internal/sqlscanner/scanner.go 96.82% <0%> (+1.58%) ⬆️
metrics.go 91.66% <0%> (+1.66%) ⬆️
context.go 94.05% <0%> (+1.98%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2773fa2...c604f21. Read the comment docs.

@axw axw merged commit 27c1659 into elastic:master Jan 7, 2019
@axw axw deleted the error-transaction-sampled branch January 7, 2019 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants