module/apmot: report error log records #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step towards removing unsupportedSpanMethods.
Implement Span.LogKV and Span.LogFields, sending error log events to Elastic APM, ignoring all other logs. We only implement this for spans created through the OT API, and not the wrapper spans synthesised for transactions/spans created via the native APM API. Span.FinishWithOptions now behaves as if LogFields were called with each of the log records in the options. If the log record timestamp is not set, then the span finish time will be used if specified, and the current time otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Span.LogKV and Span.LogFields, sending
error log events to Elastic APM, ignoring all other
logs. We only implement this for spans created
through the OT API, and not the wrapper spans
synthesised for transactions/spans created via
the native APM API.
Span.FinishWithOptions now behaves as if LogFields
were called with each of the log records in the
options. If the log record timestamp is not set,
then the span finish time will be used if specified,
and the current time otherwise.
Closes #397