Add "transaction.type" to errors #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings in error.transaction.type, and support for numeric and boolean tags.
Also, introduce generate.sh, as we now also need to run go-licenser over the fastjson-generated code.
When an error is captured within a sampled transaction, record the transaction type on the error. The transaction type is taken at the time the CaptureError function is called, or when Error.SetTransaction is called.
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 80.92% 81.03% +0.11%
==========================================
Files 104 104
Lines 6374 6396 +22
==========================================
+ Hits 5158 5183 +25
+ Misses 935 930 -5
- Partials 281 283 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add model.ErrorTransaction.Type, which may hold the type of the transaction in which an error occurs. Update apm.CaptureError and apm.Error.SetTransaction to record the transaction type on errors associated with sampled transactions.
Closes #431