Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ELASTIC_APM_DISABLE_METRICS #439

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Conversation

axw
Copy link
Member

@axw axw commented Jan 30, 2019

Introduce the config ELASTIC_APM_DISABLE_METRICS,
which disables metrics whose names match any of a list of
wildcard patterns. Currently there is no method to change this
dynamically, but the matching is done in a way to permit this
in the future.

Closes #435

@codecov-io
Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #439 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
+ Coverage   83.06%   83.11%   +0.04%     
==========================================
  Files         104      104              
  Lines        6370     6377       +7     
==========================================
+ Hits         5291     5300       +9     
+ Misses        791      790       -1     
+ Partials      288      287       -1
Impacted Files Coverage Δ
tracer.go 86.41% <100%> (+0.49%) ⬆️
env.go 82.02% <100%> (+0.41%) ⬆️
metrics.go 90.32% <100%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b66d89...55cd66c. Read the comment docs.

Introduce the config ELASTIC_APM_DISABLE_METRICS,
which disables metrics whose names match any of
a list of wildcard patterns. Currently there is
no method to change this dynamically, but the
matching is done in a way to permit this in the
future.
@axw axw merged commit 0ec17c9 into elastic:master Jan 31, 2019
@axw axw deleted the disable-metrics branch January 31, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants