apm: introduce ErrorDetailer interface #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
==========================================
+ Coverage 83.39% 84.02% +0.63%
==========================================
Files 107 108 +1
Lines 6546 6580 +34
==========================================
+ Hits 5459 5529 +70
+ Misses 796 763 -33
+ Partials 291 288 -3
Continue to review full report at Codecov.
|
axw
force-pushed
the
error-details
branch
3 times, most recently
from
7241407
to
447cc27
Compare
Introduce the ErrorDetailer interface, along with top-level functions RegisterTypeErrorDetailer and RegisterErrorDetailer. The former register an ErrorDetailer with a specific error type, and the latter registers an ErrorDetailer for all errors. When an error is created with NewError or NewErrorLog, we pass the error details through these ErrorDetailers, giving instrumentation modules and application-specific code an opportunity to extract details from custom error types.
Register an ErrorDetailer for mongo.CommandError, extract the error code and labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the ErrorDetailer interface, along with
top-level functions RegisterTypeErrorDetailer and
RegisterErrorDetailer. The former register an
ErrorDetailer with a specific error type, and the
latter registers an ErrorDetailer for all errors.
When an error is created with NewError or NewErrorLog,
we pass the error details through these ErrorDetailers,
giving instrumentation modules and application-specific
code an opportunity to extract details from custom
error types.
In module/apmmongo, we register an ErrorDetailer
that extracts details from mongo.CommandErrors.
Closes #447
Closes #443