Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module/apmelasticsearch: capture more request bodies #470

Merged
merged 2 commits into from
Mar 12, 2019

Conversation

axw
Copy link
Member

@axw axw commented Mar 12, 2019

Capture the request body for more search requests.
Previously we would capture the body only for requests
where the path ended with "/_search". We will now
match the following suffixes:

  • "/_search"
  • "/_msearch"
  • "/_search/template"
  • "/_msearch/template"
  • "/_rollup_search"

axw added 2 commits March 12, 2019 10:46
Capture the request body for more search requests.
Previously we would capture the body only for requests
where the path ended with "/_search". We will now
match the following suffixes:

 - "/_search"
 - "/_msearch"
 - "/_search/template"
 - "/_msearch/template"
 - "/_rollup_search"
@codecov-io
Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #470 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage   84.01%   84.01%   -0.01%     
==========================================
  Files         108      108              
  Lines        6608     6619      +11     
==========================================
+ Hits         5552     5561       +9     
- Misses        765      766       +1     
- Partials      291      292       +1
Impacted Files Coverage Δ
module/apmelasticsearch/client.go 93.33% <83.33%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3253f58...9012259. Read the comment docs.

@axw axw merged commit a8ab7a9 into elastic:master Mar 12, 2019
@axw
Copy link
Member Author

axw commented Mar 12, 2019

Closes #449

@axw axw deleted the apmelasticsearch-more-search-paths branch March 12, 2019 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants