Promote TraceContext to non-pooled types #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
==========================================
- Coverage 84.46% 83.82% -0.64%
==========================================
Files 113 112 -1
Lines 7164 6733 -431
==========================================
- Hits 6051 5644 -407
+ Misses 804 786 -18
+ Partials 309 303 -6
Continue to review full report at Codecov.
|
Move TraceContext from TransactionData to Transaction, and SpanData to Span. This enables an ended transaction or span to be used as the parent of a span. This is particularly important to enable fire-and-forget type patterns, where a goroutine is spawned that may start a span after the parent ends. Span now holds a reference to its enclosing transaction, enabling us to avoid calls to TransactionFromContext. This may also enable deferred transaction sampling in the future. Transactions, spans, and errors are now all sent to the tracer goroutine through a single "chan tracerEvent" channel. This change incurs a minor (~10%/~50 bytes) increase in the number of bytes allocated per transaction. There is no change in number of allocs, and no significant impact on time per operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move TraceContext from TransactionData to
Transaction, and SpanData to Span. This
enables an ended transaction or span to
be used as the parent of a span. This is
particularly important to enable
fire-and-forget type patterns, where a
goroutine is spawned that may start a span
after the parent ends.
Transactions, spans, and errors are now
all sent to the tracer goroutine through
a single "chan tracerEvent" channel.
This change incurs a minor (~10%/~50 bytes)
increase in the number of bytes allocated
per transaction. There is no change in number
of allocs, and no significant impact on time
per operation.
Partially addresses #475