Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistent transaction name for unknown-route HTTP requests #486

Closed
axw opened this issue Mar 22, 2019 · 2 comments
Closed

Ensure consistent transaction name for unknown-route HTTP requests #486

axw opened this issue Mar 22, 2019 · 2 comments

Comments

@axw
Copy link
Member

axw commented Mar 22, 2019

We should ensure consistency with other agents, and set the transaction name to "<METHOD> unknown route" for incoming HTTP requests, when the route cannot be determined.

@axw
Copy link
Member Author

axw commented Apr 4, 2019

This is a little bit complicated for gorilla/mux, since its middleware isn't invoked at all when a route cannot be matched. To support this we'll need to override the Router.NotFoundHandler and Router.MethodNotAllowedHandler fields (see https://godoc.org/github.com/gorilla/mux#Router).

@axw
Copy link
Member Author

axw commented Apr 4, 2019

Likewise for httprouter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants