-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apmchi module to support github.com/go-chi/chi #495
Conversation
2867205
to
58dea39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rliebz, this is looking great!
jenkins run the tests please |
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
==========================================
+ Coverage 83.64% 83.81% +0.17%
==========================================
Files 113 113
Lines 6566 6550 -16
==========================================
- Hits 5492 5490 -2
+ Misses 772 760 -12
+ Partials 302 300 -2
Continue to review full report at Codecov.
|
Not sure what makes Jenkins fail whenever I push, but otherwise I think it's good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the top quality PR!
LGTM, will merge after Jenkins is happy.
Our Jenkins CI only runs when instructed to by @elastic folks, preventing damage by malicious PRs. I'll get it going. |
jenkins run the tests please |
Create an
apmchi
module inmodules/
, which allows users to create middleware to log to Elastic APM. Does the standardapmhttp
stuff, but also handles parametrized paths.It can be used as follows:
Resolves #494