Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sqlutil.QuerySignature to apmsql #515

Merged
merged 1 commit into from Apr 29, 2019

Conversation

axw
Copy link
Member

@axw axw commented Apr 29, 2019

Expose QuerySignature in the apmsql module.

Closes #513

Expose QuerySignature in the apmsql module.
@codecov-io
Copy link

codecov-io commented Apr 29, 2019

Codecov Report

Merging #515 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   84.09%   84.12%   +0.02%     
==========================================
  Files         114      114              
  Lines        6729     6729              
==========================================
+ Hits         5659     5661       +2     
+ Misses        766      765       -1     
+ Partials      304      303       -1
Impacted Files Coverage Δ
module/apmsql/signature.go 100% <ø> (ø)
module/apmgorm/context.go 88.4% <100%> (ø) ⬆️
module/apmsql/driver.go 78.72% <100%> (ø) ⬆️
tracer.go 86.5% <0%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8743196...594a215. Read the comment docs.

@axw axw merged commit e4cbc85 into elastic:master Apr 29, 2019
@axw axw deleted the apmsql-expose-querysignature branch April 29, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose a function for formatting SQL span names
2 participants