apmgrpc: Add WithServerRequestIgnorer Server Option #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omri Shtamberger <omrishtam@gmail.com>
Signed-off-by: Omri Shtamberger <omrishtam@gmail.com>
…Ignorer param type Signed-off-by: Omri Shtamberger <omrishtam@gmail.com>
axw
approved these changes
May 22, 2019
module/apmgrpc/ignorer_test.go
Outdated
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "go.elastic.co/apm/module/apmgrpc" |
There was a problem hiding this comment.
Move this line to its own block below, otherwise the "goimports" check will fail.
You can use make check goimports to check your changes before pushing, or make fmt to apply the formatting rules.
Co-Authored-By: Andrew Wilkins <axwalk@gmail.com>
Co-Authored-By: Andrew Wilkins <axwalk@gmail.com>
Co-Authored-By: Andrew Wilkins <axwalk@gmail.com>
Signed-off-by: Omri Shtamberger <omrishtam@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
==========================================
+ Coverage 84.13% 84.14% +<.01%
==========================================
Files 115 116 +1
Lines 6757 6772 +15
==========================================
+ Hits 5685 5698 +13
- Misses 767 768 +1
- Partials 305 306 +1
Continue to review full report at Codecov.
|
|
Thank you for your contribution, @omrishtam! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
func WithServerRequestIgnorer(r RequestIgnorerFunc) ServerOptionfor ignoring gRPC methods, as described in #530.