-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add row_query callback to apmgorm #532
Conversation
The RowQuery callback is used when objects are queried with functions like row, rows, count, etc are executed.
Codecov Report
@@ Coverage Diff @@
## master #532 +/- ##
==========================================
+ Coverage 84.13% 84.13% +<.01%
==========================================
Files 115 115
Lines 6757 6758 +1
==========================================
+ Hits 5685 5686 +1
Misses 767 767
Partials 305 305
Continue to review full report at Codecov.
|
@axw Thanks, I assumed that commits signed by Github's key also count as signed? If not, how can I re-sign the commit with my own key? |
@Vilsol the message "Pull request contains unsigned commits" is perhaps a bit unclear. Your commits are signed and that's fine, but it appears that you have not signed the CLA. Did you already sign the CLA at https://www.elastic.co/contributor-agreement? Maybe with another email? |
(Ah, I just got what you meant. I'll have to check about using GitHub's key.) |
Ah, I got it now, the signed commits are related to the contributor agreement not GPG signing. Might want to make the error message more descriptive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. Can you please add a test that demonstrates why this is needed?
Or perhaps just modify testWithContext
in apmgorm_test.go to make an additional query that requires it?
The RowQuery callback is used when objects are queried with functions like row, rows, count, etc are executed.