Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row_query callback to apmgorm #532

Closed
wants to merge 1 commit into from
Closed

Conversation

Vilsol
Copy link

@Vilsol Vilsol commented May 19, 2019

The RowQuery callback is used when objects are queried with functions like row, rows, count, etc are executed.

The RowQuery callback is used when objects are queried with functions like row, rows, count, etc are executed.
@codecov-io
Copy link

Codecov Report

Merging #532 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
+ Coverage   84.13%   84.13%   +<.01%     
==========================================
  Files         115      115              
  Lines        6757     6758       +1     
==========================================
+ Hits         5685     5686       +1     
  Misses        767      767              
  Partials      305      305
Impacted Files Coverage Δ
module/apmgorm/context.go 88.57% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47cc289...4a9cd76. Read the comment docs.

@axw
Copy link
Member

axw commented May 22, 2019

@Vilsol thanks for the PR!

Would you please add a test?

Also, in case you haven't already noticed, there is a CLA which requires signing. Let me know if you're having trouble with that.

@Vilsol
Copy link
Author

Vilsol commented May 22, 2019

@axw Thanks, I assumed that commits signed by Github's key also count as signed? If not, how can I re-sign the commit with my own key?

@axw
Copy link
Member

axw commented May 22, 2019

@Vilsol the message "Pull request contains unsigned commits" is perhaps a bit unclear. Your commits are signed and that's fine, but it appears that you have not signed the CLA.

Did you already sign the CLA at https://www.elastic.co/contributor-agreement? Maybe with another email?

@axw
Copy link
Member

axw commented May 22, 2019

(Ah, I just got what you meant. I'll have to check about using GitHub's key.)

@Vilsol
Copy link
Author

Vilsol commented May 22, 2019

Ah, I got it now, the signed commits are related to the contributor agreement not GPG signing. Might want to make the error message more descriptive.

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. Can you please add a test that demonstrates why this is needed?
Or perhaps just modify testWithContext in apmgorm_test.go to make an additional query that requires it?

@axw
Copy link
Member

axw commented May 31, 2019

I've picked up the task of adding a test. I'll close this and continue over in #543. Thanks for the fix @Vilsol!

@axw axw closed this May 31, 2019
@axw axw removed the [zube]: Done label Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants