Optimise BodyCapturer #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
capture-body-limit-buffer
branch
from
9ad00e7
to
6da8cac
Compare
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
==========================================
+ Coverage 87.68% 87.72% +0.04%
==========================================
Files 121 121
Lines 7218 7253 +35
==========================================
+ Hits 6329 6363 +34
- Misses 791 793 +2
+ Partials 98 97 -1
Continue to review full report at Codecov.
|
We optimise apm.BodyCapturer in two ways to reduce its overhead: - BodyCapturers are now pooled: CaptureHTTPRequestBody will acquire from the pool, and the new BodyCapturer.Discard method will release back to the pool. - We no longer use io.TeeReader to read into a bytes.Buffer, as that may lead to reading the entire request body into memory. Since we truncate the captured body anyway, we now copy only a limited amount into a buffer.
axw
force-pushed
the
capture-body-limit-buffer
branch
from
6da8cac
to
2913ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We optimise apm.BodyCapturer in two ways to reduce its overhead:
acquire from the pool, and the new BodyCapturer.Discard method
will release back to the pool.
as that may lead to reading the entire request body into
memory. Since we truncate the captured body anyway, we now
copy only a limited amount into a buffer.
Fixes #580