Don't send context for non-sampled transactions #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
==========================================
+ Coverage 87.7% 87.73% +0.03%
==========================================
Files 121 121
Lines 7253 7255 +2
==========================================
+ Hits 6361 6365 +4
+ Misses 794 793 -1
+ Partials 98 97 -1
Continue to review full report at Codecov.
|
axw
force-pushed
the
non-sampled-no-context
branch
from
a4b728b
to
337de7f
Compare
Fix transaction encoding to drop any accumulated context for non-sampled transactions. We've been relying on instrumentation to not set context for non-sampled transactions. If some instrumentation (e.g. custom code) sets context, it still shouldn't be sent to the server for non-sampled transactions.
axw
force-pushed
the
non-sampled-no-context
branch
from
337de7f
to
d688e94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix transaction encoding to drop any accumulated
context for non-sampled transactions.
We've been relying on instrumentation to not
set context for non-sampled transactions. If
some instrumentation (e.g. custom code) sets
context, it still shouldn't be sent to the
server for non-sampled transactions.
Closes #583