Report error causes #638
Merged
Report error causes #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will now report complete error trees in error.exception: the top-most exception is the provided error, and any cause/wrapped error will be reported in an array of causes to the server. The error culprit will now be calculated by traversing the tree depth-first, returning the first non-library frame's function name. This will resolve issues such as elastic#632, where an error with a complete stack trace is wrapped by one with only a limited stack trace.
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
==========================================
+ Coverage 87.75% 87.81% +0.05%
==========================================
Files 123 123
Lines 7522 7582 +60
==========================================
+ Hits 6601 6658 +57
- Misses 817 819 +2
- Partials 104 105 +1
Continue to review full report at Codecov.
|
|
jenkins run the tests please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will now report complete error trees in
error.exception: the top-most exception is
the provided error, and any cause/wrapped
error will be reported in an array of causes
to the server.
We will only report at most 50 errors in a tree,
and we break cycles by just ignoring references
to previously seen errors.
The error culprit will now be calculated by
traversing the tree depth-first, returning
the first non-library frame's function name.
This will resolve issues such as #632, where
an error with a complete stack trace is
wrapped by one with only a limited stack trace.
Closes #423