Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELASTIC_APM_TRANSACTION_MAX_SPANS=0 disables spans #640

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

axw
Copy link
Member

@axw axw commented Sep 26, 2019

Setting ELASTIC_APM_TRANSACTION_MAX_SPANS=0 now disables all spans. Negative values continue to mean that there are an unlimited number of spans.

Closes #639

@axw axw force-pushed the max-spans-zero branch 2 times, most recently from 331ebdd to 0f1f945 Compare September 26, 2019 03:34
Setting ELASTIC_APM_TRANSACTION_MAX_SPANS=0 now
disables all spans. Negative values continue to
mean that there are an unlimited number of spans.
@codecov-io
Copy link

codecov-io commented Sep 26, 2019

Codecov Report

Merging #640 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
+ Coverage   87.78%   87.85%   +0.06%     
==========================================
  Files         123      123              
  Lines        7582     7582              
==========================================
+ Hits         6656     6661       +5     
+ Misses        820      816       -4     
+ Partials      106      105       -1
Impacted Files Coverage Δ
tracer.go 89.69% <ø> (+0.32%) ⬆️
span.go 94.61% <100%> (ø) ⬆️
transport/transporttest/recorder.go 86.66% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e10f18...9b6b257. Read the comment docs.

@axw axw merged commit f19dd2c into elastic:master Sep 26, 2019
@axw axw deleted the max-spans-zero branch September 26, 2019 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TRANSACTION_MAX_SPANS=0 should drop all spans
2 participants