Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module/apmzerolog: add Writer.MinLevel #641

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Conversation

axw
Copy link
Member

@axw axw commented Sep 26, 2019

Add Writer.MinLevel, which controls the minimum
level of logs to send as errors to Elastic APM.
MinLevel must be >= zerolog.ErrorLevel, otherwise
zerolog.ErrorLevel will be used as the minimum.

Closes #636

@codecov-io
Copy link

codecov-io commented Sep 26, 2019

Codecov Report

Merging #641 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #641     +/-   ##
=========================================
+ Coverage   87.78%   87.88%   +0.1%     
=========================================
  Files         123      123             
  Lines        7582     7587      +5     
=========================================
+ Hits         6656     6668     +12     
+ Misses        820      816      -4     
+ Partials      106      103      -3
Impacted Files Coverage Δ
module/apmzerolog/writer.go 72.72% <100%> (+3.57%) ⬆️
tracer.go 89.69% <0%> (+0.32%) ⬆️
transport/http.go 95.41% <0%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26a1ff...80b45f1. Read the comment docs.

Add Writer.MinLevel, which controls the minimum
level of logs to send as errors to Elastic APM.
MinLevel must be >= zerolog.ErrorLevel, otherwise
zerolog.ErrorLevel will be used as the minimum.
@axw axw merged commit 51e6605 into elastic:master Sep 26, 2019
@axw axw deleted the apmzerolog-minlevel branch September 26, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module/apmzerolog: allow user to override level checks in Writer
2 participants