Expand central config support #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #648 +/- ##
=========================================
+ Coverage 87.83% 87.9% +0.07%
=========================================
Files 123 123
Lines 7601 7640 +39
=========================================
+ Hits 6676 6716 +40
Misses 821 821
+ Partials 104 103 -1
Continue to review full report at Codecov.
|
Add central config support for ELASTIC_APM_CAPTURE_BODY and ELASTIC_APM_TRANSACTION_MAX_SPANS. The initial code for central config contained some hacks specifically around the initially supported config for controlling sampling. The code has been refactored to support additional config attributes. In doing so, we now have a single "instrumentationConfig" object on the Tracer, which gets swapped out atomically when a config change occurs, either via the API or via central config. This has the added benefit of being slightly faster, as we're no longer using RWMutexes, and also neater as we now have a single immutable config object (excluding tracer-internal config).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add central config support for ELASTIC_APM_CAPTURE_BODY
and ELASTIC_APM_TRANSACTION_MAX_SPANS.
The initial code for central config contained some hacks
specifically around the initially supported config for
controlling sampling. The code has been refactored to
support additional config attributes. In doing so, we
now have a single "instrumentationConfig" object on the
Tracer, which gets swapped out atomically when a config
change occurs, either via the API or via central config.
This has the added benefit of being slightly faster, as
we're no longer using RWMutexes, and also neater as we
now have a single immutable config object (excluding
tracer-internal config).
Closes #647