Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport: clean server URL path #658

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Conversation

axw
Copy link
Member

@axw axw commented Oct 17, 2019

Clean the server URL path, so we don't trigger redirects due to non-canonical paths at the server.

Fixes #657

Clean the server URL path, so we don't trigger
redirects due to non-canonical paths at the server.
@codecov-io
Copy link

Codecov Report

Merging #658 into master will decrease coverage by 0.49%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #658     +/-   ##
=========================================
- Coverage   88.37%   87.87%   -0.5%     
=========================================
  Files         123      123             
  Lines        7891     7640    -251     
=========================================
- Hits         6974     6714    -260     
- Misses        796      822     +26     
+ Partials      121      104     -17
Impacted Files Coverage Δ
transport/http.go 95.41% <50%> (+1.14%) ⬆️
model/marshal_fastjson.go 77.1% <0%> (-5.58%) ⬇️
breakdown.go 95.89% <0%> (-3.43%) ⬇️
tracer.go 91.03% <0%> (-0.34%) ⬇️
utils.go 82.69% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update affcad0...6f3228d. Read the comment docs.

@axw axw merged commit ba7aeb4 into elastic:master Oct 17, 2019
@axw axw deleted the transport-http-clean-path branch October 17, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing slash on ELASTIC_APM_SERVER_URL leads to GET requests
2 participants