Use direct peer socket address #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
remoteaddr-peer-address
branch
from
4264f5c
to
9ed5dde
Compare
context.request.socket.remote_address should have the direct peer socket (IP) address, not the originating client address. This means we should not parse Forwarded, X-Forwarded-For, etc. in order to determine this field's value. That should instead be left to the server.
axw
force-pushed
the
remoteaddr-peer-address
branch
from
9ed5dde
to
f4e4952
Compare
Codecov Report
@@ Coverage Diff @@
## master #662 +/- ##
=========================================
- Coverage 88.35% 87.9% -0.45%
=========================================
Files 123 123
Lines 7891 7625 -266
=========================================
- Hits 6972 6703 -269
- Misses 798 819 +21
+ Partials 121 103 -18
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context.request.socket.remote_addressshould have the direct peer socket (IP) address, not the originating client address. This means we should not parse Forwarded, X-Forwarded-For, etc. in order to determine this field's value. That should instead be left to the server.Closes #659