Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model: add Cloud metadata types #817

Merged
merged 5 commits into from
Sep 13, 2020
Merged

model: add Cloud metadata types #817

merged 5 commits into from
Sep 13, 2020

Conversation

axw
Copy link
Member

@axw axw commented Sep 10, 2020

This is part of #786. No metadata collection yet, just adding the types and a method to RecorderTracer for testing.

This unblocks translating OpenTelemetry cloud semantic conventions while we continue to work on collecting metadata in the agent.

Add a method to obtain the received Cloud metadata.
@axw axw requested a review from a team September 10, 2020 02:57
@apmmachine
Copy link
Collaborator

apmmachine commented Sep 10, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #817 updated]

  • Start Time: 2020-09-13T01:26:43.190+0000

  • Duration: 29 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 7413
Skipped 182
Total 7595

apmtest/recorder_test.go Outdated Show resolved Hide resolved
@axw
Copy link
Member Author

axw commented Sep 10, 2020

not sure why windows tests started failing all of a sudden...

@axw
Copy link
Member Author

axw commented Sep 10, 2020

jenkins run the tests please

@axw axw merged commit 7af7e15 into elastic:master Sep 13, 2020
@axw axw deleted the cloud-model branch September 13, 2020 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants