Fix gRPC status code outcome mapping, implement Gherkin outcome spec #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
"Unknown" status should be considered a failure. All status codes other than OK are failures from the client's perspective.
axw
force-pushed
the
apmgodog-http-grpc
branch
from
9c604be
to
6b68fc9
Compare
axw
force-pushed
the
apmgodog-http-grpc
branch
from
6b68fc9
to
4df9336
Compare
stuartnelson3
pushed a commit
that referenced
this pull request
Jul 30, 2021
…902) * module/apmgrpc: fix status code to outcome mapping "Unknown" status should be considered a failure. All status codes other than OK are failures from the client's perspective. * test: synchronizing gherkin specs * internal/apmgodog: implement outcome spec * Add changelog entry Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the mapping of gRPC status codes to outcomes. In particular, the "Unknown" status should be considered a failure as it describes an unknown error -- not that the status is unknown. All status codes other than OK are failures from the client's perspective.
Also, implement the Gherkin outcome spec.
Supersedes #898