New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for go-restful v3 #968
Conversation
💚 CLA has been signed |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
Sorry, forgot to sign the contributor agreement, now I have signed it, how to ask the bot to recheck my PR? edit: done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @luqmansen! Just a couple of minor issues. Please run make fmt update-modules scripts/Dockerfile-testing
, then it should be good to merge.
Hey, I updated the PR, can you please review it again? Thank you @axw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I'll just need to get it to run through CI now.
jenkins run the tests please |
@luqmansen CI looks good except that it fails on older versions of Go that don't support modules. Can you please add a build tag to each file in apmrestfulv3 except for doc.go: apm-agent-go/module/apmgopgv10/hook.go Lines 18 to 20 in 5153274
|
Sure, will update this soon |
🎉 thanks again @luqmansen! |
Thank you! @axw |
* feat: add support for go-restful v3
#967