Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture exception from spring boot @ExceptionHandler #711

Closed
felixbarny opened this issue Jul 8, 2019 · 3 comments · Fixed by #812
Closed

Capture exception from spring boot @ExceptionHandler #711

felixbarny opened this issue Jul 8, 2019 · 3 comments · Fixed by #812
Labels
good first issue Good for newcomers instrumentation Instrumentation: framework support, custom plugins, ...

Comments

@felixbarny
Copy link
Member

context: https://discuss.elastic.co/t/apm-dont-capture-exception-from-exceptionhandler/187530

@felixbarny felixbarny added instrumentation Instrumentation: framework support, custom plugins, ... framework support labels Jul 8, 2019
@videnkz
Copy link
Contributor

videnkz commented Jul 19, 2019

Hi @felixbarny , I will try to do this.

@videnkz
Copy link
Contributor

videnkz commented Jul 19, 2019

How I understand, we should instrument all methods annotated with @org.springframework.web.bind.annotation.ExceptionHandler and call captureException in current span?

@felixbarny
Copy link
Member Author

Good question. Sounds like that could introduce some overhead as we would have to scan every application class for that annotation. Maybe there's some central piece in Spring MVC which we could instrument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers instrumentation Instrumentation: framework support, custom plugins, ...
Projects
None yet
4 participants