improve servlet error capture #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eyalkoren , @felixbarny please check PR |
felixbarny
approved these changes
Aug 28, 2019
added |
eyalkoren
reviewed
Sep 1, 2019
...o/elastic/apm/agent/spring/webmvc/exception/AbstractExceptionHandlerInstrumentationTest.java
Outdated
Show resolved
Hide resolved
| .reporter(reporter) | ||
| .build(); | ||
| ElasticApmAgent.initInstrumentation(tracer, ByteBuddyAgent.install(), | ||
| Arrays.asList(new ServletInstrumentation(tracer), new ExceptionHandlerInstrumentation())); |
There was a problem hiding this comment.
If you do:
Suggested change
| Arrays.asList(new ServletInstrumentation(tracer), new ExceptionHandlerInstrumentation())); | |
| Arrays.asList(new ServletInstrumentation(tracer))); |
instead, does the relevant test fail now?
There was a problem hiding this comment.
with instrumentation:
without:
There was a problem hiding this comment.
Yes, it's failing now
There was a problem hiding this comment.
Great, then it is properly tested 🙂
Thanks!
eyalkoren
approved these changes
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
closes #711
Update documentationUpdate supported-technologies.asciidocAdded an API method or config option? Document in which version this will be introduced.