Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database link to span context #732

Closed
felixbarny opened this issue Jul 18, 2019 · 2 comments · Fixed by #735
Closed

Add database link to span context #732

felixbarny opened this issue Jul 18, 2019 · 2 comments · Fixed by #735
Labels
good first issue Good for newcomers

Comments

@felixbarny
Copy link
Member

Continuation of #676: add the db link to the span context

apm server issue: elastic/apm-server#2478

@wolframhaussig are you interested in implementing this?

@felixbarny felixbarny added the good first issue Good for newcomers label Jul 18, 2019
@wolframhaussig
Copy link
Contributor

@felixbarny I can try. But currently, the discussion in elastic/apm#107 is not yet completed so I would want to wait for that. And can you confirm what I should implement exactly as the field has to be transferred to the APM server and I am not sure if you would want to implement that youself. Just so I do not implement more than required...

@felixbarny
Copy link
Member Author

We've agreed to add the field and there's already an APM Server issue for that: elastic/apm-server#2478.

Even if there's no conclusion yet about how to parse MSSql DBLinks, we can go ahead with what we currently have.

You'd have to add a dbLink property to co.elastic.apm.agent.impl.transaction.Db, reset it to null in Db#resetState and serialize it in DslJsonSerializer.

The current APM Server would just ignore the field but once elastic/apm-server#2478 is implemented and released, the field is available in ES.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants