Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silencing log4j StatusLogger during initialization #1322

Merged
merged 4 commits into from Aug 4, 2020

Conversation

eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Aug 2, 2020

What does this PR do?

Fixes #1316

The result of the described error (and other similar errors) is falling back to the log4j default, which we expect anyway.

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else

@apmmachine
Copy link
Collaborator

apmmachine commented Aug 2, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user eyalkoren, Replayed #4]

  • Start Time: 2020-08-03T14:42:36.502+0000

  • Duration: 45 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 1435
Skipped 11
Total 1446

@eyalkoren eyalkoren merged commit b4f4a68 into elastic:master Aug 4, 2020
@eyalkoren eyalkoren deleted the log4j-error branch August 4, 2020 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants