Fix Micrometer registry serialization error due to failed meter #1741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a Micrometer meter throws Exception while trying to retrieve some meter value, the serialization of the entire metric registry will fail. If the failure is consistent, all meters of this registry would never be reported.
With this PR, a meter can fail only once, omitting a single warning, without failing the serialization of the registry.
In addition, in an attempt to fix at least one type of errors related to querying meter values, I tried to set the meter's class loader as the thread's context CL for the time of query.
NOTE FOR REVIEWER I think it's lightweight enough to do for each meter, but we can also have two caches of failed meters, so that we don't set context CL by default, try to re-execute meter query after the first failure with the context CL and if succeeds, add it to a different cache. If the second attempt fails, we can then add to the generally-disabled meters.
Checklist