Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Implementation-Title as default service name if it is available #1921

Merged
merged 40 commits into from Jan 26, 2022

Conversation

tobiasstadler
Copy link
Contributor

What does this PR do?

When the MANIFEST.MF of main jar contains the Implementation-Title attribute, it is used as the default service name.

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation

@apmmachine
Copy link
Collaborator

apmmachine commented Jul 16, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 50 min 13 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge SylvainJuge added the community Issues and PRs created by the community label Jul 27, 2021
@tobiasstadler
Copy link
Contributor Author

Could someone please have a look?

@AlexanderWert AlexanderWert moved this from In Progress to Planned in APM-Agents (OLD) Aug 23, 2021
@tobiasstadler
Copy link
Contributor Author

@SylvainJuge Maybe you can spare some time please.

@SylvainJuge
Copy link
Member

run elasticsearch-ci/docs

@tobiasstadler
Copy link
Contributor Author

@felixbarny Maybe you can spare some time please?

@AlexanderWert AlexanderWert added this to the 8.0-candidate milestone Sep 13, 2021
@SylvainJuge
Copy link
Member

Hi @tobiasstadler, we have added this to our short-term backlog.
While we can't provide guarantees nor ETA, we will try to handle it soon.

@tobiasstadler
Copy link
Contributor Author

Thank You! I am looking forward to it.

@tobiasstadler
Copy link
Contributor Author

Any chance this will make it into 1.29.0?

Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty straightforward.

It doesn't catch the Implementation-Title from within .war files but a good first step!

@felixbarny
Copy link
Member

/test

@felixbarny
Copy link
Member

run elasticsearch-ci/docs

@felixbarny felixbarny enabled auto-merge (squash) January 26, 2022 07:32
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
auto-merge was automatically disabled January 26, 2022 07:40

Head branch was pushed to by a user without write access

@eyalkoren
Copy link
Contributor

run elasticsearch-ci/docs

@felixbarny felixbarny merged commit 60233f0 into elastic:main Jan 26, 2022
APM-Agents (OLD) automation moved this from Planned to Done Jan 26, 2022
@tobiasstadler
Copy link
Contributor Author

Thank You!

@tobiasstadler tobiasstadler deleted the implementation-title branch January 26, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants