New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Implementation-Title as default service name if it is available #1921
Conversation
Could someone please have a look? |
@SylvainJuge Maybe you can spare some time please. |
run elasticsearch-ci/docs |
@felixbarny Maybe you can spare some time please? |
Hi @tobiasstadler, we have added this to our short-term backlog. |
Thank You! I am looking forward to it. |
Any chance this will make it into 1.29.0? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty straightforward.
It doesn't catch the Implementation-Title
from within .war
files but a good first step!
/test |
run elasticsearch-ci/docs |
Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
Head branch was pushed to by a user without write access
run elasticsearch-ci/docs |
Thank You! |
What does this PR do?
When the MANIFEST.MF of main jar contains the Implementation-Title attribute, it is used as the default service name.
Checklist