Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility test JDK 17 #2184

Merged
merged 17 commits into from
Dec 6, 2021
Merged

Compatibility test JDK 17 #2184

merged 17 commits into from
Dec 6, 2021

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Oct 12, 2021

What does this PR do?

Part of #1953

  • disable jdk 16 and jdk 15 compatibility tests as they produce noise for now
  • add jdk 17 to the list of tested JDKs for compatibility tests
  • upgrade maven wrapper + version to 3.8.3 + upgrade a few plugins

Checklist

TODO : add here one item in checklist per failing test that require investigation

  • System Lambda in ContainerInfoTest is not compatible with Java 16+ (see system lambda jdk 16 compatibility issue #1942 as well)
  • Log4j1.x reached EOL and MDC relies on Java version parsing
  • Change how we ensure that we don't initialize default SSL context before the application.

@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Oct 12, 2021
@SylvainJuge SylvainJuge added this to the 8.0 milestone Oct 12, 2021
@apmmachine
Copy link
Collaborator

apmmachine commented Oct 12, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-06T08:40:28.735+0000

  • Duration: 50 min 3 sec

  • Commit: 121232d

Test stats 🧪

Test Results
Failed 0
Passed 8520
Skipped 44
Total 8564

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run compatibility tests : Run the JDK Compatibility test.

  • run integration tests : Run the APM-ITs.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@felixbarny
Copy link
Member

Seems like Java 17 is not available on CI currently

Error: JAVA_HOME is not defined correctly.
 We cannot execute /var/lib/jenkins/.java/openjdk17/bin/java

@SylvainJuge SylvainJuge removed this from the 8.0 milestone Oct 12, 2021
@SylvainJuge
Copy link
Member Author

Seems like Java 17 is not available on CI currently

Error: JAVA_HOME is not defined correctly.
 We cannot execute /var/lib/jenkins/.java/openjdk17/bin/java

Yes, it's definitely missing for now, the current state:

  • openjdk 17 is part of the infra repo descriptor
  • images have been built, but there is another issue with disk space
  • ETA is about a few days for new infra images to get deployed

@SylvainJuge SylvainJuge moved this from In Progress to Blocked in APM-Agents (OLD) Oct 12, 2021
@v1v
Copy link
Member

v1v commented Oct 12, 2021

run compatibility tests

@SylvainJuge SylvainJuge moved this from Blocked to In Progress in APM-Agents (OLD) Oct 13, 2021
@SylvainJuge SylvainJuge marked this pull request as ready for review October 13, 2021 07:40
@eyalkoren
Copy link
Contributor

closes #1942

@eyalkoren eyalkoren linked an issue Oct 14, 2021 that may be closed by this pull request
@felixbarny
Copy link
Member

run compatibility tests

@felixbarny
Copy link
Member

run compatibility tests

@SylvainJuge
Copy link
Member Author

run compatibility tests

@SylvainJuge SylvainJuge requested review from jackshirazi and removed request for eyalkoren December 6, 2021 10:29
@SylvainJuge SylvainJuge merged commit 50104e9 into elastic:master Dec 6, 2021
APM-Agents (OLD) automation moved this from In Progress to Done Dec 6, 2021
@SylvainJuge SylvainJuge deleted the jdk-17 branch December 6, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

system lambda jdk 16 compatibility issue
7 participants