Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent overriding aws elastic handler when set #3205

Merged
merged 2 commits into from Jun 26, 2023

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Jun 26, 2023

What does this PR do?

Fixes #2969 by not overriding the ELASTIC_APM_AWS_LAMBDA_HANDLER environment variable.

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation

@SylvainJuge SylvainJuge self-assigned this Jun 26, 2023
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Jun 26, 2023
@apmmachine
Copy link
Collaborator

apmmachine commented Jun 26, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-06-26T14:07:04.101+0000

  • Duration: 15 min 3 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge
Copy link
Member Author

@AlexanderWert is that what you meant in the related issue comment ?

@AlexanderWert
Copy link
Member

@AlexanderWert is that what you meant in the related issue comment ?

yes, exactly

@SylvainJuge SylvainJuge marked this pull request as ready for review June 26, 2023 14:06
@github-actions
Copy link

/test

@SylvainJuge SylvainJuge enabled auto-merge (squash) June 26, 2023 14:07
@SylvainJuge SylvainJuge merged commit 776d123 into elastic:main Jun 26, 2023
17 of 23 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[DOCS] AWS Lambda doc improvements
3 participants