Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid SQS propagation introduced with #3206 #3254

Merged
merged 2 commits into from Jul 26, 2023

Conversation

JonasKunz
Copy link
Contributor

@JonasKunz JonasKunz commented Jul 25, 2023

What does this PR do?

Fixes a ClassDefNotFoundError reported in this discussion forums thread.

The invocation of the SQSHelper was moved behind the span activation to ensure that even if no span is created, baggage propagation still occurs.

This however caused the SQSHelper to be invoked for all aws services, including non-sqs ones.

Checklist

  • This is a bugfix

@JonasKunz JonasKunz added the ci:agent-integration Enables agent integration tests in build pipeline label Jul 25, 2023
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Jul 25, 2023
@JonasKunz
Copy link
Contributor Author

Fix has been tested and verified by user (link).

@JonasKunz JonasKunz marked this pull request as ready for review July 26, 2023 07:23
@github-actions
Copy link

/test

@JonasKunz JonasKunz merged commit 1b7e461 into elastic:main Jul 26, 2023
14 of 20 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done Jul 26, 2023
@JonasKunz JonasKunz deleted the sqs-bugfix branch July 26, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java ci:agent-integration Enables agent integration tests in build pipeline
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants