Bump co.elastic.clients:elasticsearch-java from 8.8.1 to 8.9.0 #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [co.elastic.clients:elasticsearch-java](https://github.com/elastic/elasticsearch-java) from 8.8.1 to 8.9.0. - [Release notes](https://github.com/elastic/elasticsearch-java/releases) - [Changelog](https://github.com/elastic/elasticsearch-java/blob/main/CHANGELOG.md) - [Commits](elastic/elasticsearch-java@v8.8.1...v8.9.0) --- updated-dependencies: - dependency-name: co.elastic.clients:elasticsearch-java dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
SylvainJuge
approved these changes
Aug 9, 2023
SylvainJuge
reviewed
Aug 11, 2023
| map.put(endpointId, endpointDef); | ||
|
|
||
| // duplicate entries for allocation-free lookup with 'es/' prefix. | ||
| map.put("es/" + endpointId, endpointDef); |
There was a problem hiding this comment.
[for reviewer] this allows to make the lookup allocation free (endpoint ID was modified before lookup in inregisterEndpointId).
| @@ -61,10 +61,14 @@ public static class RestClientTransportAdvice { | |||
|
|
|||
| private static final ElasticsearchRestClientInstrumentationHelper helper = ElasticsearchRestClientInstrumentationHelper.get(); | |||
|
|
|||
| @Advice.OnMethodEnter(suppress = Throwable.class, inline = false) | |||
There was a problem hiding this comment.
[for reviewer] instead of keeping track of the request object (which is wrapped/replaced at least twice in the new implementation), we just use a thread-local value to store the endpoint ID for the duration of the performRequest* method execution, which is enough to create the span with the correct attributes.
| @@ -38,7 +38,7 @@ public interface DetachedThreadLocal<T> { | |||
| @Nullable | |||
| T getAndRemove(); | |||
|
|
|||
| void set(T value); | |||
| void set(@Nullable T value); | |||
There was a problem hiding this comment.
[for reviewer] this annotation was already present in interface implementation.
JonasKunz
approved these changes
Aug 11, 2023
…bot/maven/co.elastic.clients-elasticsearch-java-8.9.0
SylvainJuge
deleted the
dependabot/maven/co.elastic.clients-elasticsearch-java-8.9.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps co.elastic.clients:elasticsearch-java from 8.8.1 to 8.9.0.
Commits
a98c9d6[codegen] Update to latest 8.9 API spec3d2cb30[DOCS] Changes getting started button link on landing page. (#626) (#628)7dc7491[DOCS] Temporarily redirect getting started button link on landing page. (#62...ac905b3[DOCS] Adds getting started content based on the template (#617) (#622)bf459ff[codegen] Bump versionc8fdfca[codegen] Update to latest API spec25e61a5Fix spurious JSON event emitted by JsonpUtils.copy() (#597)4c3a13bRefactor RestClientTransport to allow using other http client libraries (#584)38ec037Add pipeline setup to index and create operations (#587)9246eabThrow a TransportException when an error response cannot be parsed (#579)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)