Remove remaining threadlocals for loom support #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the remaining (Detached)ThreadLocal usages which were used for object pooling with actual object pools.
The only exception I've made is the
CachedLookupKey: I've decided to keep it as aThreadLocalbecause it is (a) very small and (b) used very frequently so that the object-pool management might hurt performance.For the
OkHttp-instrumentation I decided to stick with simply allocating: ThatStringBufferis only allocated once per HTTP-request, meaning that it should not be a noticeable bump in allocation in comparison to the allocations done for the HTTP request execution.Closes #3059.
Checklist