Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace binary propagation with UTF8 encoded text propagation #3300

Merged
merged 11 commits into from Sep 6, 2023
Merged

Replace binary propagation with UTF8 encoded text propagation #3300

merged 11 commits into from Sep 6, 2023

Conversation

JonasKunz
Copy link
Contributor

@JonasKunz JonasKunz commented Aug 25, 2023 •
edited

What does this PR do?

Closes #3017.
This change has been tested manually for sending / receiving kafka interoperability with both older elastic APM agents and the opentelemetry agent.

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation

@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Aug 25, 2023
@JonasKunz JonasKunz changed the title Kafka traceparent Replace binary propagation with UTF8 encoded text propagation Aug 25, 2023
@JonasKunz JonasKunz requested a review from a team August 25, 2023 14:49
jackshirazi
jackshirazi approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@jackshirazi jackshirazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG thank you, this leaves it so much cleaner! The only thing I suggest is to move the deleted binary header structure comment over to the KafkaRecordHeaderAccessor class, since we're still supporting that header

@JonasKunz JonasKunz enabled auto-merge (squash) September 6, 2023 12:26
@JonasKunz JonasKunz merged commit 30f5f3d into elastic:main Sep 6, 2023
13 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done Sep 6, 2023
schikin pushed a commit to schikin/apm-agent-java that referenced this pull request Oct 11, 2023
@JonasKunz @schikin
Replace binary propagation with UTF8 encoded text propagation (elasti…
00907da 
…c#3300)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackshirazi jackshirazi jackshirazi approved these changes

Assignees
No one assigned
Labels
agent-java
Projects
APM-Agents (OLD)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[META 764] Replace binary context propagation with UTF8 encoded textual headers for Otel compatibility
2 participants
@JonasKunz @jackshirazi