Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildkite: run opentelemetry benchmark #3370

Closed
wants to merge 3 commits into from
Closed

buildkite: run opentelemetry benchmark #3370

wants to merge 3 commits into from

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 18, 2023

What does this PR do?

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else

@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Oct 18, 2023
v1v
v1v commented Oct 18, 2023
View reviewed changes
.buildkite/hooks/prepare-release.sh
@@ -0,0 +1,52 @@
#!/usr/bin/env bash
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a refactor so specific things for the release pipelines are not in the same script

v1v
v1v commented Oct 18, 2023
View reviewed changes
.buildkite/load-testing.yml
@@ -1,4 +1,5 @@
# @reakaleek: This is a place holder to create the pipeline in Buildkite. I will work on it, in a follow-up.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to help with testing this pr in isolation

@v1v v1v closed this Oct 18, 2023
APM-Agents (OLD) automation moved this from In Progress to Done Oct 18, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2023

⚠️ The sha of the head commit of this PR conflicts with #3371. Mergify cannot evaluate rules on this PR. ⚠️

@v1v v1v deleted the feature/support-benchmark-otel-in-buildkite branch October 18, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
agent-java
Projects
APM-Agents (OLD)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@v1v