add option for automatic JMX retry #3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainJuge
commented
Feb 8, 2024
| } | ||
|
|
||
| @Test | ||
| void testMBeanExceptionWhenRegisteredThenOk() throws Exception { |
There was a problem hiding this comment.
[for reviewer] this tests the new behavior, every other change is mostly refactoring in this file.
SylvainJuge
commented
Feb 8, 2024
| } | ||
| return value; |
There was a problem hiding this comment.
[for reviewer] this allows to set a breakpoint to investigate the captured value when debugging.
SylvainJuge
changed the title
jackshirazi
reviewed
Feb 8, 2024
| register(jmxConfiguration.getCaptureJmxMetrics().get(), platformMBeanServer); | ||
|
|
||
| ConfigurationOption<TimeDuration> failedRetryConfig = jmxConfiguration.getFaildRetryInterval(); | ||
| long retryMillis = failedRetryConfig.getValue().getMillis(); |
There was a problem hiding this comment.
scope is inside the if statement, why here?
jackshirazi
reviewed
Feb 8, 2024
apm-agent-plugins/apm-jmx-plugin/src/main/java/co/elastic/apm/agent/jmx/JmxMetricTracker.java
Show resolved
Hide resolved
|
run docs-build |
jackshirazi
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some MBeans throw exceptions when the state they expose isn't completely initialized yet.
When the agent starts, such MBeans will be ignored by the agent as they can't be accessed and the agent requires to get their values on registration to get their type, in particular for composite attributes, this is not something that can't be known before invocation.
Checklist