New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added internal option to fully redact exceptions #3528
Conversation
👋 @JonasKunz Thanks a lot for your contribution! It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it. Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it. |
apm-agent-core/src/main/java/co/elastic/apm/agent/configuration/CoreConfiguration.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/agent/impl/transaction/Transaction.java
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/agent/impl/transaction/Transaction.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/agent/configuration/CoreConfiguration.java
Outdated
Show resolved
Hide resolved
...in/java/co/elastic/apm/agent/springwebmvc/AbstractSpringExceptionHandlerInstrumentation.java
Outdated
Show resolved
Hide resolved
...springwebmvc/exception/AbstractExceptionHandlerInstrumentationWithExceptionResolverTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.asciidoc
What does this PR do?
Adds a new, internal config optionredact_exceptions
. If enabled, application exceptions will be replaced with instances ofRedactedExceptions
with a stacktrace where the original exception would have been recorded.The config option has been added with the name
safe_exceptions
with two flags:1
enables redacted exceptions2
changes the propagation to not use the servlet-attributesThis config option can be used to try to workaround JVM bugs related to touching exceptions.
I've tried to identify all places where the redaction needs to be applied by searching for reference of both
Exception
andThrowable
: I've looked for method having those types as parameters and fields using those types.Checklist
I have made corresponding changes to the documentation