SQS instrumentation can cause Errors

[jakedaleweb]

Describe the bug

When a transaction is not set and and sqs.sendMessage is called an error is thrown:
Cannot read property 'setDestinationContext' of null

This was introduced in the SQS instrumentation added in version 3.14.0.

The problem is that span can be null here but there is no check for that case - https://github.com/elastic/apm-agent-nodejs/blob/master/lib/instrumentation/modules/aws-sdk/sqs.js#L154-L156

Expected behavior

No error, should be handled gracefully.

Environment (please complete the following information)

• OS: Linux
• Node.js version: 16.3.0
• Agent version: 3.15.0 (present in 3.14.0 upwards)

How are you starting the agent? (please tick one of the boxes)

• Calling agent.start() directly (e.g. require('elastic-apm-node').start(...))
• Requiring elastic-apm-node/start from within the source code
• Starting node with -r elastic-apm-node/start

Additional context

• Agent config options

  Click to expand

  serviceName: 'servicename',
  secretToken: 'mysecret',
  serverUrl: 'https://myserver',
  active: true
  

[jakedaleweb]

Have tried to provide all the detail I can here, but I am not overly familiar with elastic-apm-node, let me know if I can help out with any other information (:

[astorm]

Thanks for reporting @jakedaleweb -- your level of detail was perfect. We were able to reproduce the behavior you described. We've got a PR going to fix this error. If you have a moment and could test your specific crashing use case with this branch that'd be great -- but no worries if not.

[jakedaleweb]

Wow, thanks for such a speedy response. This is fantastic! 🎉

I won't have an opportunity to test this, but it looks good to me.

Thanks again!