Allow Logical Grouping of Instrumentation by Name

[astorm]

Is your feature request related to a problem? Please describe.

Instrumentation increasingly requires us to hook multiple modules, which means it's no longer easy/intuitive to enable/disable a single module's instrumentation.

Describe the solution you'd like

Modify module wrapping and disabling to allow for logic grouping of instrumentations.

Describe alternatives you've considered

Passing complexity on to users and being sad :(

Additional context

Traditionally, there's been a 1:1 relationship between the module being instrumented and the individual instrumentation-module we write. Put another way, for each entry in the MODULES array, there's been a single instrumentation file in the instrumentation/modules folder. Traditionally, access to the object retured by requiring a module has been enough for us to replace the methods we need.

However, modern javascript practices are moving towards modules having more private members. This is both a cultural change, and a technical change brought about by TypeScript. Additionally -- many projects are moving towards having multiple packages.

One example of this is Node Redis. Where older versions packaged everything under a single redis package

require('redis')

Modern versions have many packages

require('@redis/client')
require('@redis/bloom')
require('@redis/graph')
require('@redis/json')
require('@redis/search')
require('@redis/time-series')

Additionally -- the redis instrumentation requires that we instrument multiple individual exports to get at the methods and objects we need.

var MODULES = [
  [
  '@node-redis/client/dist/lib/client',
  '@node-redis/client/dist/lib/client/commands-queue',
  '@redis/client/dist/lib/client',
  '@redis/client/dist/lib/client/commands-queue',

We should modify our module loading code to allow for a logical grouping of names. Something like

var MODULES = {
    'redis': [
      'redis',
      '@node-redis/client/dist/lib/client',
      '@node-redis/client/dist/lib/client/commands-queue',
      '@redis/client/dist/lib/client',
      '@redis/client/dist/lib/client/commands-queue',
    ]
    // ...
}

The intent is to allow end-users to enable/disable instrumentation by this logic name without having to know each individual package that would need to be disabled.