Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META 793] Report FQDN for detected_hostname #3310

Closed
elastic-apm-tech opened this issue May 3, 2023 · 2 comments · Fixed by #3437
Closed

[META 793] Report FQDN for detected_hostname #3310

elastic-apm-tech opened this issue May 3, 2023 · 2 comments · Fixed by #3437
Assignees
@trentm
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
APM-Agents (OLD)
Milestone
8.9

Comments

@elastic-apm-tech
Copy link
Collaborator

elastic-apm-tech commented May 3, 2023 •
edited by trentm

See meta issue and spec for the description and details:

The spec PR: elastic/apm#805
@elastic-apm-tech elastic-apm-tech mentioned this issue May 3, 2023
Open
7 tasks
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label May 3, 2023
@estolfo estolfo added this to the 8.9 milestone May 4, 2023
@elastic-apm-tech elastic-apm-tech added this to Planned in APM-Agents (OLD) May 4, 2023
@trentm
Copy link
Member

trentm commented May 8, 2023

If/when doing this, we should consider finding doing the detected_hostname update for the Node.js agent as well, to conform to https://github.com/elastic/apm/blob/main/specs/agents/metadata.md#hostname (spec PR/discussion: elastic/apm#517)

@trentm
Copy link
Member

trentm commented May 11, 2023

Some impl notes from Steve:

FYI - I looked into the source for the .NET APIs I plan to use to collect the detected_host_name to see how they are implemented. On Windows it calls down into the native IpHlpApi, collecting what it needs from FIXED_INFO. On Linux-based operating systems it calls into getdomainname (see https://man7.org/linux/man-pages/man2/getdomainname.2.html) and falls back to uname.

@AlexanderWert AlexanderWert changed the title [META 793] Report host.domain [META 793] Report FQDN for detected_hostname Jun 13, 2023
@trentm trentm moved this from Planned to In Progress in APM-Agents (OLD) Jun 15, 2023
@trentm trentm self-assigned this Jun 15, 2023
trentm added a commit to elastic/apm-nodejs-http-client that referenced this issue Jun 20, 2023
@trentm
feat!: metadata.system.{configured_hostname,detected_hostname}, prefe…
13641c8 
…r FQDN

Refs: elastic/apm-agent-nodejs#3310
This was referenced Jun 20, 2023
Merged
Merged
trentm added a commit to elastic/apm-nodejs-http-client that referenced this issue Jun 27, 2023
@trentm
feat!: metadata.system.{configured_hostname,detected_hostname}, prefe…
a90fe47 
…r FQDN (#200)

This also adds testing of node v20 and testing on windows (just one node version).

Refs: elastic/apm-agent-nodejs#3310
APM-Agents (OLD) automation moved this from In Progress to Done Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
APM-Agents (OLD)
  
Done
Milestone
8.9
3 participants
@trentm @estolfo @elastic-apm-tech