Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package.json engines with node 10 #343

Closed
dicarlo2 opened this issue May 14, 2018 · 2 comments
Closed

Update package.json engines with node 10 #343

dicarlo2 opened this issue May 14, 2018 · 2 comments

Comments

@dicarlo2
Copy link

dicarlo2 commented May 14, 2018 •
edited by alvarolobato
Loading

It seems that node 10 is supported by apm, albeit with broken tracing (nodejs/node#20516). Still, can we get the package.json updated to have node 10 as an engine? We don't use the automatic tracing functionality and would like to move to node 10 without having to use --ignore-engines with yarn.
watson added a commit to watson/apm-agent-nodejs that referenced this issue May 14, 2018
@watson
chore: allow Node.js 10 in package.json engines field
5ab02d0 
Closes elastic#343
@watson watson mentioned this issue May 14, 2018
Merged
@watson
Copy link
Contributor

watson commented May 14, 2018

Good point. I've made a PR to address it: #345

watson added a commit that referenced this issue May 15, 2018
@watson
chore: allow Node.js 10 in package.json engines field (#345)
e28eb7f 
Closes #343
@watson
Copy link
Contributor

watson commented May 15, 2018

This have now been fixed in v1.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@watson @dicarlo2