Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move elastic-apm-http-client into this repository #3506

Closed
david-luna opened this issue Jul 25, 2023 · 0 comments · Fixed by #3507
Closed

Move elastic-apm-http-client into this repository #3506

david-luna opened this issue Jul 25, 2023 · 0 comments · Fixed by #3507
Assignees
@david-luna
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
APM-Agents (OLD)
Milestone
next-major

Comments

@david-luna
Copy link
Member

The mentioned package is meant to be used only by the nodejs APM agent and having it as a dependency it slows down the time to respond to an issue related to it since:

  • we need to implement the fix in the package
  • we need to publish a new version of it
  • we need to update the dependency in the agent (and maybe update its integration code)
  • we can finally publish the fixed version

Since a new major release is coming (4.x) the effort will be doubled since we will also keep doing maintenance of 3.x. So for the sake of better maintenance of both versions we should include the sources of the apm-client into the agent. With this approach we will have:

  • less steps to publish a fix
  • easier backporting of that fix to 3.x

There is already a module inside the agent named apm-client waiting for the code to be included there.
@david-luna david-luna added the agent-nodejs Make available for APM Agents project planning. label Jul 25, 2023
@david-luna david-luna added this to the next-major milestone Jul 25, 2023
This was referenced Jul 25, 2023
Merged
Merged
@trentm trentm mentioned this issue Jul 26, 2023
Closed
@trentm trentm moved this from Planned to In Progress in APM-Agents (OLD) Jul 26, 2023
APM-Agents (OLD) automation moved this from In Progress to Done Jul 29, 2023
trentm added a commit that referenced this issue Jul 29, 2023
@david-luna @trentm
chore: move 'elastic-apm-http-client' package code into this repo (#3507
8b68529 
)

This moves the apm-nodejs-http-client.git code into 
"{lib,test}/apm-client/http-apm-client/..." in this repo. This will
help maintenance of multiple active branches of the APM agent.

The only changes are to rename the export to `HttpApmClient` and adjust
require paths. Some functions were moved from lib/apm-client/http-apm-client.js
to lib/apm-client/apm-client.js to clarify.

Closes: #3506
Co-authored-by: Trent Mick <trent.mick@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-luna david-luna

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
APM-Agents (OLD)
  
Done
Milestone
next-major
Development

Successfully merging a pull request may close this issue.

chore: include http apm client elastic/apm-agent-nodejs
1 participant
@david-luna