Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use external as span type #1291

Merged
merged 1 commit into from Sep 20, 2019
Merged

feat: use external as span type #1291

merged 1 commit into from Sep 20, 2019

Conversation

Qard
Copy link
Contributor

@Qard Qard commented Aug 15, 2019 •
edited by zube bot

Rather than the shortened 'ext' use full 'external' in span types

Fixes #1225

Checklist

  • Implement code
  • Add tests

@Qard Qard requested a review from watson August 15, 2019 18:46
@Qard Qard self-assigned this Aug 15, 2019
watson
watson previously approved these changes Aug 19, 2019
View reviewed changes
@v1v
Copy link
Member

v1v commented Aug 19, 2019

For the record, continuous-integration/jenkins/pr-merge should point out to https://apm-ci.elastic.co/job/apm-agent-nodejs/job/apm-agent-nodejs-mbp/job/PR-1291/1/. The reason why it's not reflecting that particular link is related to the test local environments in my end.

@watson watson added this to the v3.0.0 milestone Aug 23, 2019
@Qard
feat: use external as span type
14265f2 
Rather than the shortened 'ext' use full 'external' in span types

Fixes elastic#1225
@watson watson merged commit 7e7cade into elastic:master Sep 20, 2019
watson added a commit to watson/apm-agent-nodejs that referenced this pull request Sep 20, 2019
@watson
test: fix http disabling test
a659ac8 
The PR elastic#1298 introduced a bug in the tests as it expected the span.type
for outgoing http requests to start with `ext.*`. This was changed to
`external.*` in the PR elastic#1291, but elastic#1298 was just never updated to be up
to date with master before it was merged.
@watson watson mentioned this pull request Sep 20, 2019
Merged
watson added a commit that referenced this pull request Sep 20, 2019
@watson
test: fix http disabling test (#1367)
7c88ca3 
The PR #1298 introduced a bug in the tests as it expected the span.type
for outgoing http requests to start with `ext.*`. This was changed to
`external.*` in the PR #1291, but #1298 was just never updated to be up
to date with master before it was merged.
@Qard Qard deleted the external-span-type branch September 20, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watson watson watson left review comments

Assignees

@Qard Qard

Labels
breaking change enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use span.type: external instead of span.type: ext
3 participants
@Qard @v1v @watson