Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't throw on invalid URL #1771

Merged
merged 2 commits into from Jul 22, 2020
Merged

Conversation

watson
Copy link
Member

@watson watson commented Jun 4, 2020

I would prefer a proper fix for this where proxies are supported, but for now, this will have to do. I've opened an issue to add proper support for this: #1770.

Fixes #1769

@watson watson self-assigned this Jun 4, 2020
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Are we going to use this as an interim solution till we find a way to solve proxy URL's?

@apmmachine
Copy link
Collaborator

apmmachine commented Jun 11, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #1771 updated]

  • Start Time: 2020-07-22T16:03:27.538+0000

  • Duration: 18 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 167253
Skipped 0
Total 167253

Steps errors

Expand to view the steps failures

  • Name: Download Codecov
    • Description: #!/bin/bash set -x curl -sSLo codecov.sh https://codecov.io/bash

    • Duration: 2 min 22 sec

    • Start Time: 2020-07-22T16:18:09.880+0000

    • log

@vigneshshanmugam vigneshshanmugam merged commit ec61513 into elastic:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError [ERR_INVALID_URL] [ERR_INVALID_URL]: Invalid URL
3 participants